Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #861460

SDL activity button tooltips say activities will take far more turns than they really will

Added by Jacob Nevins about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui-sdl2
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In both SDL clients, the tooltip for the round activity buttons like "irrigate" at the bottom of the screen says things like "Irrigate to Swamp (M) 150 turns", which is clearly far too long.

It's calling tile_activity_time(), but not taking into account the selected unit's get_activity_rate(), so everything is scaled by ACTIVITY_FACTOR. (So presumably the tooltip is also not scaled by the greater work rate of, say, Engineers vs Workers.)

m-sdl-order-button-turns.patch (10.2 KB) m-sdl-order-button-turns.patch Jacob Nevins, 2020-02-23 05:21 PM
30-sdl-order-button-turns.patch (9.23 KB) 30-sdl-order-button-turns.patch Jacob Nevins, 2020-02-23 05:21 PM
26-sdl-order-button-turns.patch (12.6 KB) 26-sdl-order-button-turns.patch Jacob Nevins, 2020-02-23 05:21 PM
26_classic_terrainchange.sav.bz2 (13.4 KB) 26_classic_terrainchange.sav.bz2 S2_6 savegame useful for testing Jacob Nevins, 2020-02-23 05:21 PM

Related issues

Blocked by Freeciv - Feature #861498: Reduce/improve ruleset hardcoding around irrigation/mining actions in SDL clientsClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #861509: Middle-click tile popup very confused in rulesets where multiple activities can create/remove a single extraClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Feature #861501: SDL: make base and cleaning order buttons display specific extra and turns to completionClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Jacob Nevins

#2 Updated by Jacob Nevins about 1 year ago

  • Blocked by Feature #861498: Reduce/improve ruleset hardcoding around irrigation/mining actions in SDL clients added

#3 Updated by Jacob Nevins about 1 year ago

  • Blocked by Bug #861509: Middle-click tile popup very confused in rulesets where multiple activities can create/remove a single extra added

#6 Updated by Jacob Nevins about 1 year ago

  • Blocks Feature #861501: SDL: make base and cleaning order buttons display specific extra and turns to completion added

#7 Updated by Jacob Nevins about 1 year ago

  • Status changed from Resolved to Closed

The turns_to_activity_done() added in this patch might also be useful in other clients.

Also available in: Atom PDF