Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #861499

SDL clients still think per-unit autoattack is a thing

Added by Jacob Nevins 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui-sdl2
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The SDL clients have some dead code to change the "automate unit" button to have the label/icon "Auto Attack" (normally it is "Auto Settler").

This code can't be reached, since it's inside tautologous checks for settler-type units. Individual unit auto-attack is not currently a thing, so it should should be removed.

(This leaves one of the order button icons in the SDL theme more obviously orphaned.)

m-30-sdl-no-autoattack.patch (3.06 KB) m-30-sdl-no-autoattack.patch Jacob Nevins, 2020-02-23 05:21 PM
26-sdl-no-autoattack.patch (6.38 KB) 26-sdl-no-autoattack.patch Jacob Nevins, 2020-02-23 05:22 PM

Related issues

Blocks Freeciv - Bug #861500: Never-used initial order button tooltip strings in SDL clientsClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins 11 months ago

#2 Updated by Jacob Nevins 11 months ago

  • Blocks Bug #861500: Never-used initial order button tooltip strings in SDL clients added

#3 Updated by Jacob Nevins 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF