HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #861867
Reduce/improve ruleset hardcoding around irrigation/mining actions in Qt client
0%
Description
Similar to feature #861498:
The Qt client has some UI hardcoding suited to the classic ruleset. In unit_actions::update_actions()
:
verbatim
if (!strcmp(terrain_rule_name(pterrain), "Jungle")
|| !strcmp(terrain_rule_name(pterrain), "Plains")
|| !strcmp(terrain_rule_name(pterrain), "Grassland")
|| !strcmp(terrain_rule_name(pterrain), "Swamp")) {
a->set_pixmap(fc_icons::instance()->get_pixmap("plantforest"));
} else {
a->set_pixmap(fc_icons::instance()->get_pixmap("transform"));
}verbatim
(etc)
While it would be best to be rid of this hardcoding, it can probably be improved in the same way as the SDL client (here by looking at mining_result
to see if it is "Forest", rather than assuming the classic-ruleset set of pre-Forest terrains).
Related issues
History
#1
Updated by Jacob Nevins about 1 year ago
(Oops, tried to use Gna markup out of habit. You know what I meant...)
#2
Updated by Jacob Nevins about 1 year ago
- Related to Feature #861498: Reduce/improve ruleset hardcoding around irrigation/mining actions in SDL clients added
#3
Updated by Jacob Nevins about 1 year ago
- File m-qt-mine-irrig-hardcoding.patch m-qt-mine-irrig-hardcoding.patch added
- File 30-26-qt-mine-irrig-hardcoding.patch 30-26-qt-mine-irrig-hardcoding.patch added
- Status changed from New to Resolved
- Assignee set to Jacob Nevins
#4
Updated by Jacob Nevins about 1 year ago
- Status changed from Resolved to Closed