Bug #863755: Qt client HUD prints "Gold: ... (+-2)" if player is losing gold per turn - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #863755

Qt client HUD prints "Gold: ... (+-2)" if player is losing gold per turn

Added by Jacob Nevins almost 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

gui-qt

Sprint/Milestone:

2.6.3

Start date:

Due date:

% Done:

Estimated time:

Description

It's got a hardcoded + sign rather than a %+d style construction, so it only works well while you are saving gold.

QString doesn't make it easy to fix this, but it's possible with a bit of fiddling.

m-30-26-qt-hud-losing-gold.patch (1000 Bytes) m-30-26-qt-hud-losing-gold.patch	master, S3_0, S2_6	Jacob Nevins, 2020-03-07 04:22 PM
0001-Fix-a-QString-.sprintf-call-even-when-libintl.h-make.patch (1.56 KB) 0001-Fix-a-QString-.sprintf-call-even-when-libintl.h-make.patch		Marko Lindqvist, 2020-03-22 10:28 AM
0001-Fix-msys-Qt-client-build.patch (1.43 KB) 0001-Fix-msys-Qt-client-build.patch		Marko Lindqvist, 2020-04-06 04:11 AM

Related issues

History

#1 Updated by Jacob Nevins almost 2 years ago

File m-30-26-qt-hud-losing-gold.patch m-30-26-qt-hud-losing-gold.patch added
Status changed from In Progress to Resolved

#2 Updated by Jacob Nevins almost 2 years ago

Status changed from Resolved to Closed

#3 Updated by Marko Lindqvist almost 2 years ago

I suspect this one broke msys2 build. More likely by revealing an existing bug than by having an bug in itself. More info when I have it, but 'sprintf()' might be a macro that fits badly to QString::sprintf() usage.

#4 Updated by Marko Lindqvist almost 2 years ago

Status changed from Closed to New

Not yet sure if the msys2 issue should be resolved as adjustment to this ticket or as a separate change, but reopening this until otherwise decided.

#5 Updated by Marko Lindqvist almost 2 years ago

Blocks Task #851229: S3_0 alpha4 added

#6 Updated by Jacob Nevins almost 2 years ago

Fine to reopen from my point of view.

Can you quote the error message (or whatever) from the msys2 build?

#7 Updated by Marko Lindqvist almost 2 years ago

Error message:

In file included from ../../../../../utility/fcintl.h:34,
from ../../../../../utility/specenum_gen.h:123,
from ../../../../../common/fc_types.h:145,
from ../../../../../common/movement.h:20,
from ../../../../../client/gui-qt/hudwidget.cpp:35:
../../../../../client/gui-qt/hudwidget.cpp: In function 'void show_new_turn_info()':
../../../../../client/gui-qt/hudwidget.cpp:1690:22: error: 'class QString' has no member named 'libintl_sprintf'
1690 | .arg(QString().sprintf("%+d",

with 'sprintf' in the last line colored.