Bug #868533: clang-10 tautological-compare warnings - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187

Actions

Send by e-mail Copy link

Bug #868533

closed

clang-10 tautological-compare warnings

Added by Marko Lindqvist almost 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

General

Sprint/Milestone:

2.6.2.1

Start date:

Due date:

% Done:

Estimated time:

Description

Some warnings seen when compiling with clang-10. I were compiling S3_0, but likely all branches are affected.

Will attach logs later.

Files

Download all files

errors.log (487 KB) errors.log		Marko Lindqvist, 2020-04-10 09:02 AM
0006-debug.m4-Set-always-active-compiler-flags-last-not-f.patch (1.88 KB) 0006-debug.m4-Set-always-active-compiler-flags-last-not-f.patch		Marko Lindqvist, 2020-04-22 03:04 AM

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Blocks Task #851229: S3_0 alpha4 added

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

File errors.log errors.log added
Category set to General

These tautological-compare errors come from generated sources (packets_gen.c, specenum_gen.h)

Either we need to fix the code generation (if it can be made safely) or to disable tautological-compare warnings.

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Subject changed from clang-10 warnings to clang-10 tautological-compare warnings

Well, we already disable tautological-compare warnings, but apparently clang-10 does not care about it. Consider this a compiler bug? I don't have any good ideas for a workaround.

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Blocks deleted (Task #851229: S3_0 alpha4)

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Sprint/Milestone set to 2.6.3

Ubuntu-20.04 LTS has clang-10, and warnings (or errors with --enable-debug) are coming up from all branches. However, there the warning seems to be more fine-grained type than already disabled tautological-compare, so we may can fix it by disabling that specific warning.

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

After some testing with different compiler commandlines makes me suspect that the problem is in order of the parameters. We set -Wno-tautological-compare before -Wall. Latter again enables the warning that former had disabled.

Actions

Copy link