Bug #870968: deprecated-declarations warnings with Qt-5.14 - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187

Actions

Send by e-mail Copy link

Bug #870968

closed

deprecated-declarations warnings with Qt-5.14

Added by Marko Lindqvist almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Bootstrap

Sprint/Milestone:

2.6.3

Start date:

Due date:

% Done:

Estimated time:

Description

Trying to compile S3_0 against development version of crosser-1.10, which has Qt-5.14.2 results in deprecated-declarations errors (warnings turned to errors by -Werror).
This is despite the fact that we have QT_DISABLE_DEPRECATED_BEFORE at Qt-5.2 level only. Qt seems to have no mechanism to allow deprecations above certain version level - that's either a missing feature or a bug, but apparently we need to live with it.

Setting '-Wno-error=deprecated-declarations', or maybe just '-Wno-deprecated-declarations', for --enable-debug builds should work as a quick workaround, and the only one I have figured out so far.

So far this issue has been seen with crosser build only. As such it would affected only S3_0 and later. S2_6 might very well be affected, but I'd rather backport the workaround only when the issue has been confirmed on that branch.

Files

Download all files

0010-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch (1.25 KB) 0010-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch	master, S3_0	Marko Lindqvist, 2020-04-27 12:46 AM
0008-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch (1.21 KB) 0008-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch	S2_6	Marko Lindqvist, 2020-04-27 12:47 AM

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

File 0010-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch 0010-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch added
File 0008-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch 0008-Set-Wno-deprecated-declarations-to-CXXFLAGS-of-enabl.patch added
Status changed from In Progress to Resolved
Sprint/Milestone changed from 3.0.0 to 2.6.3

The simpler solution, -Wno-deprecated-declarations, works. I think this one is fine even for S2_6.

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

FWIW The deprecated declarations warnings are given only about QDesktopWidget::screenGeometry() stuff we resolve (for master) in Feature #871396

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

I think we should push this patch (silencing of the warning) to stable branches, where the deprecation is not going to get fixed, only. Leave it out from master, and instead follow how the situation develops with the future Qt versions.

Actions

Copy link