Bug #874406: Trade plan calculation fails Qt 2.6.2 client - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #874406

Trade plan calculation fails Qt 2.6.2 client

Added by Alexandro Ignatiev about 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

gui-qt

Sprint/Milestone:

2.6.2.1

Start date:

Due date:

% Done:

Estimated time:

Description

The client hangs for a while and then fails. 2.6.1 does not have this bug.

0029-Qt-Fix-hang-on-trade-planning-calculation.patch (2.59 KB) 0029-Qt-Fix-hang-on-trade-planning-calculation.patch	master	Marko Lindqvist, 2020-10-23 02:50 AM
0017-Qt-Fix-hang-on-trade-planning-calculation.patch (2.59 KB) 0017-Qt-Fix-hang-on-trade-planning-calculation.patch	S3_0, S2_6	Marko Lindqvist, 2020-10-23 02:50 AM
0029-Qt-Fix-hang-on-trade-planning-calculation.patch (2.59 KB) 0029-Qt-Fix-hang-on-trade-planning-calculation.patch	master	Marko Lindqvist, 2020-10-23 07:10 AM
0010-Qt-Fix-hang-on-trade-planning-calculation.patch (2.59 KB) 0010-Qt-Fix-hang-on-trade-planning-calculation.patch	S3_0, S2_6	Marko Lindqvist, 2020-10-23 07:10 AM

Related issues

History

#1 Updated by Alexandro Ignatiev about 2 years ago

Most probably, the error comes from a wrong resolution in bug #852857: std::sort requires a function that behaves as a stable comparison operator, qrand() is not one. It seems to be no standard random shuffle function in stdlib.h, but there are lots of code patterns around that do the task.

#2 Updated by Marko Lindqvist almost 2 years ago

Alexandro Ignatiev wrote:

Most probably, the error comes from a wrong resolution in bug #852857

It should be easy to test by reverting that patch. I don't think anything has built on top of it since.

#3 Updated by Marko Lindqvist over 1 year ago

Alexandro Ignatiev wrote:

qrand() is not one.

Also, it seems qrand() has been deprecated in Qt-5.15.

#4 Updated by Marko Lindqvist over 1 year ago

File 0029-Qt-Fix-hang-on-trade-planning-calculation.patch 0029-Qt-Fix-hang-on-trade-planning-calculation.patch added
File 0017-Qt-Fix-hang-on-trade-planning-calculation.patch 0017-Qt-Fix-hang-on-trade-planning-calculation.patch added
Status changed from New to Resolved

Does this patch help?

#5 Updated by Marko Lindqvist over 1 year ago

Status changed from Resolved to In Progress

clang gives a warning:
../../../../src/client/gui-qt/menu.cpp:222:5: error: struct 'trade_city' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
struct trade_city *cities_order[count];
^
../../../../src/client/gui-qt/menu.h:136:7: note: previous use is here
class trade_city
^
../../../../src/client/gui-qt/menu.cpp:222:5: note: did you mean class here?
struct trade_city *cities_order[count];
^_~~~
class
1 error generated.