HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187
Bug #874406
closed
Trade plan calculation fails Qt 2.6.2 client
0%
Description
The client hangs for a while and then fails. 2.6.1 does not have this bug.
Files
Related issues
Updated by Alexandro Ignatiev almost 3 years ago
Most probably, the error comes from a wrong resolution in bug #852857: std::sort requires a function that behaves as a stable comparison operator, qrand() is not one. It seems to be no standard random shuffle function in stdlib.h, but there are lots of code patterns around that do the task.
Updated by Marko Lindqvist almost 3 years ago
Alexandro Ignatiev wrote:
Most probably, the error comes from a wrong resolution in bug #852857
It should be easy to test by reverting that patch. I don't think anything has built on top of it since.
Updated by Marko Lindqvist over 2 years ago
Alexandro Ignatiev wrote:
qrand()is not one.
Also, it seems qrand() has been deprecated in Qt-5.15.
Updated by Marko Lindqvist over 2 years ago
- File 0029-Qt-Fix-hang-on-trade-planning-calculation.patch 0029-Qt-Fix-hang-on-trade-planning-calculation.patch added
- File 0017-Qt-Fix-hang-on-trade-planning-calculation.patch 0017-Qt-Fix-hang-on-trade-planning-calculation.patch added
- Status changed from New to Resolved
Does this patch help?
Updated by Marko Lindqvist over 2 years ago
- Status changed from Resolved to In Progress
clang gives a warning:
../../../../src/client/gui-qt/menu.cpp:222:5: error: struct 'trade_city' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
struct trade_city *cities_order[count];
^
../../../../src/client/gui-qt/menu.h:136:7: note: previous use is here
class trade_city
^
../../../../src/client/gui-qt/menu.cpp:222:5: note: did you mean class here?
struct trade_city *cities_order[count];
^~~~
class
1 error generated.
Updated by Marko Lindqvist over 2 years ago
- File 0029-Qt-Fix-hang-on-trade-planning-calculation.patch 0029-Qt-Fix-hang-on-trade-planning-calculation.patch added
- File 0010-Qt-Fix-hang-on-trade-planning-calculation.patch 0010-Qt-Fix-hang-on-trade-planning-calculation.patch added
- Status changed from In Progress to Resolved
- Fixed compile with clang
Updated by Marko Lindqvist over 2 years ago
- Blocks Feature #892509: Make Qt-5.15 minimum requirement for --with-qt5x builds added
Updated by Marko Lindqvist over 2 years ago
Marko Lindqvist wrote:
Does this patch help?
Ping, Alexandro Ignatiev
Updated by Marko Lindqvist over 2 years ago
- Blocks Feature #893343: QT_DISABLE_DEPRECATED_BEFORE to match Qt-5.15 added
Updated by Marko Lindqvist over 2 years ago
- Blocks deleted (Feature #892509: Make Qt-5.15 minimum requirement for --with-qt5x builds)
Updated by Marko Lindqvist over 2 years ago
Marko Lindqvist wrote:
Does this patch help?
Worked at least in my own quick test, so pushing soon.
Updated by Marko Lindqvist over 2 years ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist
Updated by Marko Lindqvist over 2 years ago
- Sprint/Milestone changed from 2.6.3 to 2.6.2.1
.