HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Feature #878898
Share embassy knowledge between teammates
0%
Description
Team is considered unbreakable alliance, if one knows what enemy does, it is shared between all teammates, currently in pictures off-game. Redesign it so that it's shared automatically. Don't change how tech leakage by embassies works though. Example commit (backport to 2.6, idk if it works for 3.x): https://github.com/Ihnatus/freeciv/commit/923932fa7798a75203c3599e5227543635d013b9
Related issues
History
#1
Updated by Marko Lindqvist over 1 year ago
- Status changed from New to In Progress
- Sprint/Milestone changed from 3.0.0 to 2.6.3
I'd want cleaner solution. By making team mate's real embassy look like embassy effect already lead you to trouble forcing you to make more hacky code to research_total_bulbs_required().
I'll try to make alternative patch myself.
#2
Updated by Marko Lindqvist over 1 year ago
- File 0015-Share-intelligence-from-embassy-to-team-members.patch 0015-Share-intelligence-from-embassy-to-team-members.patch added
Untested patch for master that adds team_has_embassy() function, and calls it instead of player_has_embassy() where ever the question is about getting intelligence information. There's several cases where it is not called instead of player_has_embassy(). Most notable such functional difference to your patch is that meeting between players is not enabled by an embassy of an teammate.
One thing to review is if client side has enough information for its calls to team_has_embassy() to work sensibly.
#3
Updated by Marko Lindqvist over 1 year ago
- Sprint/Milestone changed from 2.6.3 to 3.0.0
Marko Lindqvist wrote:
One thing to review is if client side has enough information for its calls to team_has_embassy() to work sensibly.
Yes, client knows if there's an embassy between other players, if client has embassy - or equivalent info - with the player who owns embassy to third player.
Not targeting to S2_6 as too risky change for mature branch, and someone might even consider this a rule change.
#4
Updated by Marko Lindqvist over 1 year ago
- File 0016-Share-intelligence-from-embassy-to-team-members.patch 0016-Share-intelligence-from-embassy-to-team-members.patch added
- Status changed from In Progress to Resolved
#5
Updated by Marko Lindqvist over 1 year ago
- Blocks Task #896713: S3_0-alpha5 added
#6
Updated by Marko Lindqvist over 1 year ago
This is waiting testing. I would appreciate if someone did it.
#7
Updated by Marko Lindqvist over 1 year ago
- Status changed from Resolved to In Progress
When a team member establish an embassy, it doesn't immediately become possible for the other team member (gui) to access the information - presumably we're lacking player information refresh.
#8
Updated by Marko Lindqvist over 1 year ago
- File 0009-Share-intelligence-from-embassy-to-team-members.patch 0009-Share-intelligence-from-embassy-to-team-members.patch added
- File 0002-Share-intelligence-from-embassy-to-team-members.patch 0002-Share-intelligence-from-embassy-to-team-members.patch added
- Status changed from In Progress to Resolved
- Added sending necessary player info updates to clients
#9
Updated by Marko Lindqvist over 1 year ago
- Blocks Bug #765366: inaccurate foreign intelligence report added
#10
Updated by Marko Lindqvist over 1 year ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist