Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #885093

Wrong outputs in city dialog when celebrations are up to end

Added by Alexandro Ignatiev 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
Client
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Yet another city processing WYSIWTF effect that is just not consecutive within itself. When a city has tile outputs depending on celebrations, it celebrates but with rearranging citizens ends to, the city dialog shows non-celebrating tile outputs on the map BUT the cumulative values of outputs (turns to finish and all in its box) still use celebrating outputs of the tiles. As testers say, the map is right here.

History

#1 Updated by Marko Lindqvist 6 months ago

  • Status changed from New to In Progress

graf wasili has promised to look at this:

#4 Updated by Marko Lindqvist 6 months ago

- Please add a comment that even if celebration is about to end, it's still effective in the end of this turn. So we don't look at this code again in a couple of years, think it's wrong (not taking in to account that celebration ends), and "fix" it back
- Call base_city_celebrating() only once instead of separate call for each output type (store result to a variable and use that variable)

#5 Updated by Marko Lindqvist 6 months ago

Also, I would appreciate if you could make your patches with 'git format-patch'.
See http://www.freeciv.org/wiki/How_to_Contribute#How_to_create_patch_file_with_Git
That would make you the author of the commit (instead of just being an mention in the commit message), will allow you to write also the commit message (use 'git log' to see past commits for the commit message format we are using - in this particular case include line "Reported by Alexandro Ignatiev" as the commit author (you) and the original reporter are not the same person), and generally make things easier for the maintainer handling the patch.

#6 Updated by Marko Lindqvist 6 months ago

New version of the patch from graf wasili, with two typo corrections by me. One typo was in a comment, and another one in name of the function being called, breaking compile.

#7 Updated by Marko Lindqvist 6 months ago

Renaming the badly named functions -> Feature #892734

#8 Updated by Marko Lindqvist 6 months ago

Can someone test the final version of the patch?

#9 Updated by Marko Lindqvist 6 months ago

graf wasili wanted this patch to be put on hold until it's decided if server side behavior is the actual bug.

#10 Updated by Marko Lindqvist 5 months ago

  • Status changed from Resolved to In Progress

There's now Feature #893403 to handle all of the celebration timing game logic issues. Meanwhile I think this ticket should go forward, especially in stable branches where the other changes are unlikely to occur, but also as an interim solution in master.

graf wasili has promised an updated version of this patch, though, to better reflect the situation in comments.

#11 Updated by Marko Lindqvist 5 months ago

Marko Lindqvist wrote:

graf wasili has promised an updated version of this patch, though, to better reflect the situation in comments.

Attached.

#12 Updated by Marko Lindqvist 5 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF