Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #885482

Client fails at unspecified unit activity target

Added by Alexandro Ignatiev 8 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Category:
Client
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This bug is not noticed with a standard server build but got on an experimental one in a Gtk 3.22 client: if unit's activity requires target (it was Pillage) but it is not set, the client, trying to get the appropriate sprite (rmact), gets segfault. IMHO it should be more tolerant to server errors.


Related issues

Related to Freeciv - Bug #887748: Segfault in Qt client city dialogClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#2 Updated by Alexandro Ignatiev 7 months ago

  • Related to Bug #887748: Segfault in Qt client city dialog added

#3 Updated by Alexandro Ignatiev 7 months ago

Wrote a patch. Clients will still fail in a ruleset that lacks any extras but I doubt nothing else will fail with such a ruleset. Maybe the first patch should also auto-find an appropriate extra as the second one does.

#4 Updated by Marko Lindqvist 5 months ago

Alexandro Ignatiev wrote:

Maybe ... should also auto-find an appropriate extra

As this is clearly an server error situation that should never happen, I don't think it makes sense to build much functionality to cater for it. Attached patch just adds check that makes client more robust i.e., avoids the crash, but does not otherwise try to fix the situation.

#5 Updated by Marko Lindqvist 4 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF