Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #885725

Remove selling wonders offers from city dialogs

Added by Alexandro Ignatiev 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Client
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In the city dialog (tested in Gtk3.22) each building built has a tooltip "Press ENTER or double-click to sell" while wonders can't be sold.

History

#1 Updated by Marko Lindqvist 3 months ago

graf wasili posted attached patch for this ticket to freeciv-dev. https://www.freelists.org/post/freeciv-dev/Patch-for-Issue-885725

#2 Updated by Marko Lindqvist 3 months ago

I think we should have some tooltip also for wonders. That way user first checking with a wonder would notice that there are tooltips associated with these entries and would then check it for non-wonders too. As it's now, user probably looks around the city dialog in her initial town and concludes that there is no tooltips for the buildings as that's the situation with the Palace.
First I thought something like "Wonders cannot be sold", but maybe even better is to have different message for Small Wonders and Great Wonders, for the sake of users who are not familiar with the Small Wonder concept and who would not understand why Palace is called wonder. So, my proposal is "Small Wonder - cannot sell" and "Great Wonder - cannot sell".

Minor style nit: Add space between "/*" and first character of the comment, likewise between last character and "*/"

#3 Updated by Marko Lindqvist 3 months ago

New version from graf wasili with following changes by me:
- Applied also to gtk3 and gtk3x clients
- Removed some trailing spaces

It didn't apply cleanly to S2_6/S3_0 gtk2-client, so, assuming we want gtk2-client changed too, didn't make version for those branches.

#4 Updated by Marko Lindqvist 3 months ago

S2_6/S3_0 version from graf wasili

#5 Updated by Marko Lindqvist 3 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF