Bug #887581: Lua console featured text brings stack to overflow - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #887581

Lua console featured text brings stack to overflow

Added by Alexandro Ignatiev about 1 year ago. Updated 11 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Client

Sprint/Milestone:

2.6.2.1

Start date:

Due date:

% Done:

Estimated time:

Description

Say you want to share with your allies the data about which of your units have no upkeep. If your player number is 0, you write:

for u in find.player(28):units_iterate() do if u.homecity <= 0 then log.normal('\\[l tgt="unit" id=%d name="%s" /\\]',u.id,u.utype:rule_name()) end end

You expect to get links to copy into chat but all you get is segfault from stack overflow.
Most likely some flaw is in featured_text_to_plain_text()
but I could not catch it.

0001-Auto-close-tags-at-the-end-of-featured-texts.patch (997 Bytes) 0001-Auto-close-tags-at-the-end-of-featured-texts.patch		Alexandro Ignatiev, 2020-09-19 06:56 PM
0001-Auto-close-tags-at-the-end-of-featured-texts.patch (993 Bytes) 0001-Auto-close-tags-at-the-end-of-featured-texts.patch	without "- 1"	Alexandro Ignatiev, 2020-10-15 08:51 PM

History

#1 Updated by Alexandro Ignatiev about 1 year ago

Oops it's not only console related. When I wrote the lines to the chat manually I can't any more log on the server from Gtk3.22 clients. Other clients work, just don't show the cursed stuff.

#2 Updated by Alexandro Ignatiev about 1 year ago

File 0001-Auto-close-tags-at-the-end-of-featured-texts.patch 0001-Auto-close-tags-at-the-end-of-featured-texts.patch added

Resolved for me (Linux/Gtk3.22). This sometimes produces links with zero visible content (but still clickable) but it seems to be the solution least changing the behaviour.