HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #899339
Assert failures when reading broken specfile format
0%
Description
I've got asserts failing when reading invalid tilespec specfile format. That broken format is not an error in freeciv code (to assert) but in custom data file. What's especially bad about this is that it's not only additional assert output that comes out, but the overall behavior changes, and eventual error messages to the user are worse when asserts are enabled. I assume this to be because of some too early return from some function with fc_assert_ret_val() or similar.
History
#1
Updated by Marko Lindqvist 8 months ago
- Category set to General
- Status changed from New to In Progress
- Sprint/Milestone set to 2.6.3
This is about inf_sanity_check() and especially about calls to it within fc_assert_ret_val()
#2
Updated by Marko Lindqvist 8 months ago
- File 0018-Avoid-returning-too-early-in-assert-builds-when-inf_.patch 0018-Avoid-returning-too-early-in-assert-builds-when-inf_.patch added
- File 0015-Avoid-returning-too-early-in-assert-builds-when-inf_.patch 0015-Avoid-returning-too-early-in-assert-builds-when-inf_.patch added
- Status changed from In Progress to Resolved
Marko Lindqvist wrote:
I assume this to be because of some too early return from some function with fc_assert_ret_val() or similar.
Attached patches helps with this. There might still be cases where behavior with asserting and assertless builds differ, but my test-case (and in that a typical specfile error) works with this change. I'll leave figuring out which of the asserts should not be failing at all to a new ticket.
#3
Updated by Marko Lindqvist 8 months ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist
.