Bug #900828: -Wshadow warnings in C++ code - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #900828

History

#1 Updated by Marko Lindqvist 6 months ago

Blocked by Bug #900975: Qt shadows: mr_menu member functions with menu_list variable added

#2 Updated by Marko Lindqvist 6 months ago

Blocked by Bug #901860: Qt shadows: chat_input::chat_word_list_changed() parameter word_list shadows data member added

#3 Updated by Marko Lindqvist 6 months ago

Sprint/Milestone set to 3.1.0

In the past we briefly had -Wshadow in CXXFLAGS, but that had to be reverted as old versions of Qt had shadow problems in their headers. If we're going to enable -Wshadow in CXXFLAGS again, it can't happen in S2_6 or S3_0 where such old Qt versions are still supported.

#4 Updated by Marko Lindqvist 6 months ago

Marko Lindqvist wrote:

In the past we briefly had -Wshadow in CXXFLAGS, but that had to be reverted as old versions of Qt had shadow problems in their headers

https://web.archive.org/web/20170307022423/http://gna.org/bugs/?24005

#5 Updated by Marko Lindqvist 4 months ago

Blocked by Bug #914093: Qt shadows: hud_battle_log::timerEvent() shadow warning because of foreach() usage added

#6 Updated by Marko Lindqvist 4 months ago

Blocked by Bug #912471: Qt shadows: citydlg local 'pcity' variables shadowing data member by the same name added

#7 Updated by Marko Lindqvist 4 months ago

Blocked by Bug #914100: Qt shadows: cityrep.cpp shadow warnings in master added

#8 Updated by Marko Lindqvist 4 months ago

Blocked by Bug #918786: Qt shadows: menu.cpp foreach() inside foreach() shadow warnings added

#9 Updated by Marko Lindqvist 4 months ago

Blocked by Feature #918824: Qt: Drop unused fc_client::game_layout added

#10 Updated by Marko Lindqvist 4 months ago

Blocked by Bug #918890: Qt shadows: Shadow warnings from pages.cpp added

#11 Updated by Marko Lindqvist 3 months ago

Blocked by Bug #919310: Qt shadows: plr_report::toggle_ai_mode() 'level' shadow warning added

#12 Updated by Marko Lindqvist 3 months ago

Blocked by Bug #919445: Qt shadows: Multiple shadow warnings from repodlgs.cpp in S3_1 & master added

#13 Updated by Marko Lindqvist 3 months ago

Blocked by Bug #919733: Ruledit shadows: effect_edit::add_effect_to_list() shadow warning added

#14 Updated by Marko Lindqvist 3 months ago

Blocked by Bug #921179: Ruledit shadows: tab_enabler::update_enabler_info() added

#15 Updated by Marko Lindqvist 3 months ago

Blocked by Bug #921208: Ruledit shadows: req_edit::fill_active() shadow warning about 'data' added

#16 Updated by Marko Lindqvist 2 months ago

Subject changed from -Wshadow warnings in Qt-client code to -Wshadow warnings in C++ code

#17 Updated by Marko Lindqvist about 2 months ago

Blocked by Bug #923440: Ruledit shadows: req_vec_fix::req_vec_fix() shadow warning added

#18 Updated by Marko Lindqvist about 2 months ago

File 0041-Enable-shadow-warnings-in-C-code.patch 0041-Enable-shadow-warnings-in-C-code.patch added
Status changed from New to Resolved

#19 Updated by Marko Lindqvist about 2 months ago

Status changed from Resolved to Closed
Assignee set to Marko Lindqvist