Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #900828

-Wshadow warnings in C++ code

Added by Marko Lindqvist 11 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
gui-qt
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We currently enable -Wshadow in CFLAGS, but not in CXXFLAGS. Our Qt-client code produces several shadow warnings when they are enabled. Fix those.


Related issues

Blocked by Freeciv - Bug #900975: Qt shadows: mr_menu member functions with menu_list variableClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #901860: Qt shadows: chat_input::chat_word_list_changed() parameter word_list shadows data memberClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #914093: Qt shadows: hud_battle_log::timerEvent() shadow warning because of foreach() usageClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #912471: Qt shadows: citydlg local 'pcity' variables shadowing data member by the same nameClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #914100: Qt shadows: cityrep.cpp shadow warnings in masterClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #918786: Qt shadows: menu.cpp foreach() inside foreach() shadow warningsClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Feature #918824: Qt: Drop unused fc_client::game_layoutClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #918890: Qt shadows: Shadow warnings from pages.cppClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #919310: Qt shadows: plr_report::toggle_ai_mode() 'level' shadow warningClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #919445: Qt shadows: Multiple shadow warnings from repodlgs.cpp in S3_1 & masterClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #919733: Ruledit shadows: effect_edit::add_effect_to_list() shadow warningClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #921179: Ruledit shadows: tab_enabler::update_enabler_info()Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #921208: Ruledit shadows: req_edit::fill_active() shadow warning about 'data'Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Bug #923440: Ruledit shadows: req_vec_fix::req_vec_fix() shadow warningClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist 11 months ago

  • Blocked by Bug #900975: Qt shadows: mr_menu member functions with menu_list variable added

#2 Updated by Marko Lindqvist 11 months ago

  • Blocked by Bug #901860: Qt shadows: chat_input::chat_word_list_changed() parameter word_list shadows data member added

#3 Updated by Marko Lindqvist 11 months ago

  • Sprint/Milestone set to 3.1.0

In the past we briefly had -Wshadow in CXXFLAGS, but that had to be reverted as old versions of Qt had shadow problems in their headers. If we're going to enable -Wshadow in CXXFLAGS again, it can't happen in S2_6 or S3_0 where such old Qt versions are still supported.

#4 Updated by Marko Lindqvist 11 months ago

Marko Lindqvist wrote:

In the past we briefly had -Wshadow in CXXFLAGS, but that had to be reverted as old versions of Qt had shadow problems in their headers

https://web.archive.org/web/20170307022423/http://gna.org/bugs/?24005

#5 Updated by Marko Lindqvist 10 months ago

  • Blocked by Bug #914093: Qt shadows: hud_battle_log::timerEvent() shadow warning because of foreach() usage added

#6 Updated by Marko Lindqvist 10 months ago

  • Blocked by Bug #912471: Qt shadows: citydlg local 'pcity' variables shadowing data member by the same name added

#7 Updated by Marko Lindqvist 10 months ago

  • Blocked by Bug #914100: Qt shadows: cityrep.cpp shadow warnings in master added

#8 Updated by Marko Lindqvist 9 months ago

  • Blocked by Bug #918786: Qt shadows: menu.cpp foreach() inside foreach() shadow warnings added

#9 Updated by Marko Lindqvist 9 months ago

#10 Updated by Marko Lindqvist 9 months ago

  • Blocked by Bug #918890: Qt shadows: Shadow warnings from pages.cpp added

#11 Updated by Marko Lindqvist 9 months ago

  • Blocked by Bug #919310: Qt shadows: plr_report::toggle_ai_mode() 'level' shadow warning added

#12 Updated by Marko Lindqvist 9 months ago

  • Blocked by Bug #919445: Qt shadows: Multiple shadow warnings from repodlgs.cpp in S3_1 & master added

#13 Updated by Marko Lindqvist 9 months ago

  • Blocked by Bug #919733: Ruledit shadows: effect_edit::add_effect_to_list() shadow warning added

#14 Updated by Marko Lindqvist 8 months ago

  • Blocked by Bug #921179: Ruledit shadows: tab_enabler::update_enabler_info() added

#15 Updated by Marko Lindqvist 8 months ago

  • Blocked by Bug #921208: Ruledit shadows: req_edit::fill_active() shadow warning about 'data' added

#16 Updated by Marko Lindqvist 8 months ago

  • Subject changed from -Wshadow warnings in Qt-client code to -Wshadow warnings in C++ code

#17 Updated by Marko Lindqvist 7 months ago

  • Blocked by Bug #923440: Ruledit shadows: req_vec_fix::req_vec_fix() shadow warning added

#19 Updated by Marko Lindqvist 7 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF