Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. *Read more...*
Actions
Send by e-mail Copy link

Bug #900828

closed

-Wshadow warnings in C++ code

Added by Marko Lindqvist about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
gui-qt
Sprint/Milestone:
3.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We currently enable -Wshadow in CFLAGS, but not in CXXFLAGS. Our Qt-client code produces several shadow warnings when they are enabled. Fix those.

Files

0041-Enable-shadow-warnings-in-C-code.patch (1.04 KB) 0041-Enable-shadow-warnings-in-C-code.patch Marko Lindqvist, 2021-03-21 12:35 AM

Related issues

Blocked by Freeciv - Bug #900975: Qt shadows: mr_menu member functions with menu_list variableClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #901860: Qt shadows: chat_input::chat_word_list_changed() parameter word_list shadows data memberClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #914093: Qt shadows: hud_battle_log::timerEvent() shadow warning because of foreach() usageClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #912471: Qt shadows: citydlg local 'pcity' variables shadowing data member by the same nameClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #914100: Qt shadows: cityrep.cpp shadow warnings in masterClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #918786: Qt shadows: menu.cpp foreach() inside foreach() shadow warningsClosedMarko Lindqvist

Actions
Blocked by Freeciv - Feature #918824: Qt: Drop unused fc_client::game_layoutClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #918890: Qt shadows: Shadow warnings from pages.cppClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #919310: Qt shadows: plr_report::toggle_ai_mode() 'level' shadow warningClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #919445: Qt shadows: Multiple shadow warnings from repodlgs.cpp in S3_1 & masterClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #919733: Ruledit shadows: effect_edit::add_effect_to_list() shadow warningClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #921179: Ruledit shadows: tab_enabler::update_enabler_info()ClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #921208: Ruledit shadows: req_edit::fill_active() shadow warning about 'data'ClosedMarko Lindqvist

Actions
Blocked by Freeciv - Bug #923440: Ruledit shadows: req_vec_fix::req_vec_fix() shadow warningClosedMarko Lindqvist

Actions
Actions
Copy link
 #1

Updated by Marko Lindqvist about 2 years ago

  • Blocked by Bug #900975: Qt shadows: mr_menu member functions with menu_list variable added
Actions
Copy link
 #2

Updated by Marko Lindqvist about 2 years ago

  • Blocked by Bug #901860: Qt shadows: chat_input::chat_word_list_changed() parameter word_list shadows data member added
Actions
Copy link
 #3

Updated by Marko Lindqvist about 2 years ago

  • Sprint/Milestone set to 3.1.0

In the past we briefly had -Wshadow in CXXFLAGS, but that had to be reverted as old versions of Qt had shadow problems in their headers. If we're going to enable -Wshadow in CXXFLAGS again, it can't happen in S2_6 or S3_0 where such old Qt versions are still supported.

Actions
Copy link
 #4

Updated by Marko Lindqvist about 2 years ago

Marko Lindqvist wrote:

In the past we briefly had -Wshadow in CXXFLAGS, but that had to be reverted as old versions of Qt had shadow problems in their headers

https://web.archive.org/web/20170307022423/http://gna.org/bugs/?24005

Actions
Copy link
 #5

Updated by Marko Lindqvist about 2 years ago

  • Blocked by Bug #914093: Qt shadows: hud_battle_log::timerEvent() shadow warning because of foreach() usage added
Actions
Copy link
 #6

Updated by Marko Lindqvist about 2 years ago

  • Blocked by Bug #912471: Qt shadows: citydlg local 'pcity' variables shadowing data member by the same name added
Actions
Copy link
 #7

Updated by Marko Lindqvist about 2 years ago

  • Blocked by Bug #914100: Qt shadows: cityrep.cpp shadow warnings in master added
Actions
Copy link
 #8

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #918786: Qt shadows: menu.cpp foreach() inside foreach() shadow warnings added
Actions
Copy link
 #9

Updated by Marko Lindqvist almost 2 years ago

Actions
Copy link
 #10

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #918890: Qt shadows: Shadow warnings from pages.cpp added
Actions
Copy link
 #11

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #919310: Qt shadows: plr_report::toggle_ai_mode() 'level' shadow warning added
Actions
Copy link
 #12

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #919445: Qt shadows: Multiple shadow warnings from repodlgs.cpp in S3_1 & master added
Actions
Copy link
 #13

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #919733: Ruledit shadows: effect_edit::add_effect_to_list() shadow warning added
Actions
Copy link
 #14

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #921179: Ruledit shadows: tab_enabler::update_enabler_info() added
Actions
Copy link
 #15

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #921208: Ruledit shadows: req_edit::fill_active() shadow warning about 'data' added
Actions
Copy link
 #16

Updated by Marko Lindqvist almost 2 years ago

  • Subject changed from -Wshadow warnings in Qt-client code to -Wshadow warnings in C++ code
Actions
Copy link
 #17

Updated by Marko Lindqvist almost 2 years ago

  • Blocked by Bug #923440: Ruledit shadows: req_vec_fix::req_vec_fix() shadow warning added
Actions
Copy link
 #19

Updated by Marko Lindqvist almost 2 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist
Actions
Send by e-mail Copy link

Also available in: Atom PDF