Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #901860

Qt shadows: chat_input::chat_word_list_changed() parameter word_list shadows data member

Added by Marko Lindqvist 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
gui-qt
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

With -Wshadow set to CXXFLAGS:

../../../../src/client/gui-qt/chatline.cpp: In member function ‘virtual void chat_input::chat_word_list_changed(const QStringList&)’:
../../../../src/client/gui-qt/chatline.cpp:237:60: error: declaration of ‘word_list’ shadows a member of ‘chat_input’ [-Werror=shadow]
237 | void chat_input::chat_word_list_changed(const QStringList &word_list) | ~~~~~~~~~~~~~~~~~~^~~~~~~~
../../../../src/client/gui-qt/chatline.cpp:54:13: note: shadowed declaration is here
54 | QStringList chat_listener::word_list = QStringList(); | ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
make2: *** [Makefile:905: chatline.lo] Error 1


Related issues

Blocks Freeciv - Bug #900828: -Wshadow warnings in C++ codeClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist 4 months ago

#2 Updated by Marko Lindqvist 4 months ago

  • Blocks Bug #900828: -Wshadow warnings in C++ code added

#3 Updated by Marko Lindqvist 4 months ago

  • Sprint/Milestone changed from 2.6.3 to 2.6.4

#4 Updated by Marko Lindqvist 3 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF