Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #901938

Validate city worker tasks

Added by Sveinung Kvilhaugsvik 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

A corrupt worker task can cause issues. Refuse to accept bad worker tasks sent over the network. Purge corrupt worker tasks that gets into a city via a bug or a savegame.

0002-Validate-city-worker-tasks.patch (5.12 KB) 0002-Validate-city-worker-tasks.patch Sveinung Kvilhaugsvik, 2020-12-01 04:18 PM
2.6-Validate-city-worker-tasks.patch (6.19 KB) 2.6-Validate-city-worker-tasks.patch Sveinung Kvilhaugsvik, 2020-12-01 05:28 PM
3.0-Validate-city-worker-tasks.patch (7.14 KB) 3.0-Validate-city-worker-tasks.patch Sveinung Kvilhaugsvik, 2020-12-01 05:33 PM
3.1-Validate-city-worker-tasks.patch (7.3 KB) 3.1-Validate-city-worker-tasks.patch Sveinung Kvilhaugsvik, 2020-12-01 05:33 PM

Related issues

Related to Freeciv - Bug #887748: Segfault in Qt client city dialogClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Sveinung Kvilhaugsvik 5 months ago

3.1 only patch for now. I suspect this problem exists in earlier versions of Freeciv too. Will check later.

#2 Updated by Sveinung Kvilhaugsvik 5 months ago

  • Related to Bug #887748: Segfault in Qt client city dialog added

#3 Updated by Sveinung Kvilhaugsvik 5 months ago

  • Sprint/Milestone changed from 3.1.0 to 2.6.3

#4 Updated by Marko Lindqvist 5 months ago

sanitycheck.c runs only in debug builds. Don't rely on it to do stuff that needs to be done in release builds (such as fixing old savegames that have been corrupted by Bug #887748)

It would be good to get savegame fixing to 2.6.3.

#5 Updated by Sveinung Kvilhaugsvik 5 months ago

Marko Lindqvist wrote:

sanitycheck.c runs only in debug builds.

Thank you for pointing this out.

#7 Updated by Sveinung Kvilhaugsvik 5 months ago

  • File deleted (3.1-Validate-city-worker-tasks.patch)

#8 Updated by Sveinung Kvilhaugsvik 5 months ago

  • File deleted (3.0-Validate-city-worker-tasks.patch)

#9 Updated by Sveinung Kvilhaugsvik 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF