Help has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #905143

Inline is_city_center()

Added by Marko Lindqvist over 1 year ago. Updated over 1 year ago.

Start date:
Due date:
% Done:


Estimated time:


is_city_center() is only used in a couple of places, so inlining it to those would not cause significant executable size growth. One of the callers is tile_city(), which profiling shows to be one of the functions taking most CPU time due to fact that it's called extremely often. inlining is_city_center() to it would save function call overhead, and compiler could drop checks that are duplicated in tile_city() and is_city_center().

0044-Inline-is_city_center.patch (4.39 KB) 0044-Inline-is_city_center.patch master Marko Lindqvist, 2020-12-11 12:23 AM
0022-Inline-is_city_center.patch (4.08 KB) 0022-Inline-is_city_center.patch S3_0 Marko Lindqvist, 2020-12-11 12:23 AM
0013-Inline-is_city_center.patch (4.38 KB) 0013-Inline-is_city_center.patch S2_6 Marko Lindqvist, 2020-12-11 12:24 AM


#1 Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone set to 2.6.4

Not targeting to soon-to-be-released 2.6.3, but to 2.6.4, due to fact that the way this makes headers to depend on each other is quite messy. There's a risk that some build setup or target gets broken, so better to take time for this to be in testing before release.

#3 Updated by Marko Lindqvist over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF