Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #907977

Helping build a wonder in allied city doesn't send updated city info to city owner

Added by Ilkka Virta 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In civ2civ3, it's possible to use a Caravan to help build a wonder in an allied city. It works fine, but the owner of the city doesn't get the updated city info but sees the old progress, until they change production or reconnect to the server.

Looks like a send_city_info() should be added to accompany the text message.

The same patch should apply to S2_6 and master.

History

#1 Updated by Ilkka Virta 4 months ago

250

Screenshot of the issue

#2 Updated by Marko Lindqvist 4 months ago

  • Status changed from New to Resolved
  • Assignee set to Marko Lindqvist
  • Sprint/Milestone set to 2.6.3

Please add reference to the tracking ticket (hrm ticket at the moment, but that may change soon) to the commit message in the future. No need to do anything for this patch - I edited the commit message myself in my tree.

#3 Updated by Marko Lindqvist 4 months ago

Haven't checked the code, but maybe it should send to city owner instead of caravan owner, not in addition to it. Why would caravan owner need an update that other allies are not getting?

#4 Updated by Marko Lindqvist 4 months ago

Marko Lindqvist wrote:

Haven't checked the code, but maybe it should send to city owner instead of caravan owner, not in addition to it. Why would caravan owner need an update that other allies are not getting?

Current patch is anyway an improvement, and safer to add than not sending to caravan owner. I think we can push this to 2.6.3, and leave the adjustment to a new ticket.

#5 Updated by Ilkka Virta 4 months ago

Marko Lindqvist wrote:

Haven't checked the code, but maybe it should send to city owner instead of caravan owner, not in addition to it. Why would caravan owner need an update that other allies are not getting?

Yes, that's a good question. As far as I can see, the Caravan should only affect production values, and they're not visible to other players anyway, even allies with shared vision. Only way to see them is to go investigate with a Spy, right? But a spurious update is in any case better than getting stuck with stale data.

There's also a call to send_player_info_c(pplayer, pplayer->connections); in the function, and I'm not exactly sure if anything in player info can change here? However, it does beg the question if that, too, should be done for city owner along with the caravan owner if different.

#6 Updated by Marko Lindqvist 4 months ago

Marko Lindqvist wrote:

leave the adjustment to a new ticket.

-> Feature #908746

#7 Updated by Marko Lindqvist 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF