Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #909515

Qt(S3_0) SIGSEGV in write_shortcuts() during exit; worst case, shortcuts not saved.

Added by John Robertson 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
gui-qt
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Thread 1 received signal SIGSEGV, Segmentation fault.
write_shortcuts () at shortcuts.cpp:772
772 s.setValue("id", sc->id);
(gdb) p sc
$1 = (fc_shortcut *) 0x0

Added a NULL check, fixing the fallout, ... lack of code familiarity keeps me from knowing if the empty shortcut slot should be addressed. Also not sure if this is seen by other users or if it particular to my environment where I switch between branches.

History

#1 Updated by Marko Lindqvist 7 months ago

  • Category set to gui-qt

I would guess that this what has happened:

1) Your shortcuts were written by master client before Bug #856551 fix made master to use its own settings. Master has more shortcuts than S3_0
2) When you load shortcuts to S3_0, only first num_shortcuts shortcuts are read. Master-specific ones are within that set, taking slots from some of the S3_0 shortcuts that instead are only after the num_shortcuts limit.
3) When you try to save shortcuts again, it fails to find those S3_0 shortcuts that were left out.

You probably want to run S3_0 client once as 'freeciv-qt -- --shortcutreset' to clear all the problems you may have because of the messed up shortcuts.

As for the patch, I think we should fix the problem in that point (or preferably already when reading the shortcuts in), instead of again writing out broken shortcuts settings.

#2 Updated by Marko Lindqvist 7 months ago

  • Sprint/Milestone set to 2.6.4

Marko Lindqvist wrote:

As for the patch, I think we should fix the problem in that point (or preferably already when reading the shortcuts in), instead of again writing out broken shortcuts settings.

... and these precautions we should implement even to S2_6.

#4 Updated by Marko Lindqvist 6 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF