Bug #910832: gtk chat message crash on link tag - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #910832

gtk chat message crash on link tag

Added by Marko Lindqvist 21 days ago. Updated 19 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

gui-gtk-3.22

Sprint/Milestone:

2.6.3

Start date:

Due date:

% Done:

Estimated time:

Description

Reported by louis94 in irc.

gtk-clients sometimes crash when receiving link tags.

The problem seems to be in that we g_object_unref() the tag, despite it been created by gtk_text_buffer_create_tag() that is documented not to give ownership of the created tag to us. ("The returned tag is owned by the buffer’s tag table")

I think this is serious enough to go to 2.6.3, even to postpone it if the fix cannot be handled in time.

0034-gtk-Fix-crash-on-receiving-chat-with-link-tags.patch (2.91 KB) 0034-gtk-Fix-crash-on-receiving-chat-with-link-tags.patch	master	Marko Lindqvist, 2020-12-29 02:52 AM
0031-gtk-Fix-crash-on-receiving-chat-with-link-tags.patch (2.91 KB) 0031-gtk-Fix-crash-on-receiving-chat-with-link-tags.patch	S3_0, S2_6	Marko Lindqvist, 2020-12-29 02:52 AM