Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #915700

Control -mwindows linker flag ourselves, from one place

Added by Marko Lindqvist 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
Bootstrap
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Refactor configure code so that we can say in just one place whether Windows clients/modpack installers/ruledit use -mwindows linker flag. Currently each binary has the flag set separately, and sometimes (all clients with sound support) we get it from SDL2_LIBS.

History

#3 Updated by Marko Lindqvist 9 months ago

- Master: Correctly handle SOUND_LIBS also when it's got from pkg-conf (or especially then)
- S3_0: First version

I will be pushing these to individual branches as I get them tested (review period has certainly passed by then), not waiting all branches to be ready.

#4 Updated by Marko Lindqvist 9 months ago

  • Status changed from Resolved to In Progress

#5 Updated by Marko Lindqvist 9 months ago

- S2_6 patch that is a commit candidate.

Problems have been found with current S3_0 and master patches, so they are no longer considered for committing.

#6 Updated by Marko Lindqvist 9 months ago

New master and S3_0 patches

- Pass mwindows to freeciv-mp-qt.exe build when needed
Simplify ruledit handling (no need to check for MINGW before applying MWINDOWS_FLAG, as MWINDOWS_FLAG is already set depending on MINGW)
- S3_0 only: Handle also gtk2 modpack installer

#7 Updated by Marko Lindqvist 9 months ago

Master patch pushed

#8 Updated by Marko Lindqvist 9 months ago

S3_0 patch pushed

#9 Updated by Marko Lindqvist 9 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

S2_6 patch pushed

Also available in: Atom PDF