Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #918815

Clean up is_citytile_in_range()

Added by Sveinung Kvilhaugsvik 2 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

  • Convert from if statement to switch statement.
  • Move the no target tile check to the top.

History

#2 Updated by Marko Lindqvist 2 months ago

I'd prefer asserts against illegal ranges to be within switch statement, instead of legal ranges return;ing and illegal ones break;ing from the switch to the assert that follows outside the switch.

I also notice that you currently open also all S3_0/master targeted tickets in hrm. Please consider using osdn for getting experience about it in our pilot. ( https://www.freelists.org/post/freeciv-dev/Apparently-We-cant-have-new-user-accounts-to-hostedredmine,7 )

#3 Updated by Sveinung Kvilhaugsvik 2 months ago

Marko Lindqvist wrote:

I also notice that you currently open also all S3_0/master targeted tickets in hrm. Please consider using osdn for getting experience about it in our pilot. ( https://www.freelists.org/post/freeciv-dev/Apparently-We-cant-have-new-user-accounts-to-hostedredmine,7 )

I'll try to sign up for an account soonish. I'm not fully up to speed yet. I haven't even gotten through my Freeciv-email yet.

#5 Updated by Sveinung Kvilhaugsvik 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF