Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #919970

"Unit Move" action enabler.

Added by Sveinung Kvilhaugsvik 22 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Make regular moves action enabler controlled. This is - as far as I know - the last unit action that isn't enabler controlled. This allows simplifying away the code that gives regular moves action-like properties, like running a regular move right after an action performer, allowing moves to be blocked by actions and the action selection dialogue's "Keep Moving" button.

To reach an acceptable state much of the move cost should be moved to the ruleset too. (Fake generalization + effects)

If "Unit Move" isn't in an acceptable state by the time of the ruleset format freeze it should be made an internal action, kept out of the ruleset. That would still allow it to use the more well tested code for real actions.


Related issues

Related to Freeciv - Feature #850768: path finding: explicit alight/disembark supportNew

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Freeciv - Feature #919971: Internal action support.New

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Freeciv - Feature #920229: ANEK: cover all existing explanations why a move may failNew

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Sveinung Kvilhaugsvik 22 days ago

  • Related to Feature #850768: path finding: explicit alight/disembark support added

#2 Updated by Sveinung Kvilhaugsvik 22 days ago

#3 Updated by Sveinung Kvilhaugsvik 19 days ago

  • Related to Feature #920229: ANEK: cover all existing explanations why a move may fail added

#4 Updated by Sveinung Kvilhaugsvik 19 days ago

Included in this patch is the replacement of the action selection dialogue's "Keep moving" button, the removal of the custom handling for actions.move_is_blocked_by and the removal of various "do a move action or regular move"-code. Clean ups of other areas aren't included in this patch.

The optimizations required to make it possible to move the movement cost to the ruleset are not included, neither is the move of that cost itself.

#6 Updated by Sveinung Kvilhaugsvik 18 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF