Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #921005

Replace checks for "CanOccupyCity" unit class flag in AI and advisors

Added by Alina L. about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
AI
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Replace UCF_CAN_OCCUPY_CITY checks in server/advisors/advdata.c and ai/default/aiunit.c with calls to utype_can_take_over() or unit_can_take_over() in order to centralize "can this unit conquer cities?" logic and ultimately phase out UCF_CAN_OCCUPY_CITY.

History

#1 Updated by Alina L. about 2 months ago

Attached patch should work (read: compiles without errors) on master, S3_1, and S3_0. Autogame on master also looks normal.

#2 Updated by Sveinung Kvilhaugsvik about 2 months ago

A line is supposed to be max 77 chars. I can do this edit myself if it is OK for you.

I also edited your commit message with a space between hrm and issue number and a line break.

#3 Updated by Alina L. about 2 months ago

Ah, right – completely forgot about that. Here's an amended patch.

#4 Updated by Sveinung Kvilhaugsvik about 2 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Alina L. to Sveinung Kvilhaugsvik

Thank you for your patch!

#5 Updated by Sveinung Kvilhaugsvik about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF