Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #921208

Ruledit shadows: req_edit::fill_active() shadow warning about 'data'

Added by Marko Lindqvist 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
freeciv-ruledit
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When shadow warnins enabled:

../../../../src/tools/ruledit/req_edit.cpp: In member function ‘void req_edit::fill_active()’:
../../../../src/tools/ruledit/req_edit.cpp:268:21: error: declaration of ‘data’ shadows a member of ‘req_edit’ [-Werror=shadow]
268 | struct uvb_data data; | ^~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qframe.h:44,
from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qlabel.h:44,
from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QLabel:1,
from ../../../../src/tools/ruledit/req_edit.cpp:20:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:747:18: note: shadowed declaration is here
747 | QWidgetData *data; | ^~~~


Related issues

Blocks Freeciv - Bug #900828: -Wshadow warnings in C++ codeClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist 4 months ago

  • Blocks Bug #900828: -Wshadow warnings in C++ code added

#3 Updated by Marko Lindqvist 3 months ago

  • Sprint/Milestone changed from 3.0.0-beta1 to 3.0.0-beta2

#4 Updated by Marko Lindqvist 3 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF