Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #943039

Crash in lua Tile:is_enemy

Added by Edward Cree about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

common/scriptcore/api_game_methods:api_methods_enemy_tile() will assert if called on an empty tile. This appears to be because the guard ptile != NULL before the city_owner(pcity) call should instead check that pcity != NULL.

Observed on fc21, but code inspection suggests the same issue is present on master.

History

#1 Updated by Marko Lindqvist about 2 months ago

Thanks. Fix for all branches (S3_0+) attached.

Please open future tickets in the new bug tracker at https://osdn.net/projects/freeciv/ticket/

#2 Updated by Edward Cree about 2 months ago

You might want to change the "About" information on https://github.com/freeciv/freeciv/, then, as that still points here ☺

#3 Updated by Marko Lindqvist about 2 months ago

Edward Cree wrote:

You might want to change the "About" information on https://github.com/freeciv/freeciv/, then, as that still points here ☺

Oops. The README.md there was correct, but had missed the github "About" field. Fixed. Thanks.

#4 Updated by Marko Lindqvist about 2 months ago

  • Status changed from Approved to Closed

Also available in: Atom PDF