HostedRedmine by Planio

2021-06-07

• 
  Lexxie L Freeciv

  05:07 AM · Commented on issue

  FYI, I don't think this patch fixed the second bug, where extreme edge cases made negative bribe costs Bug #929034: Units costing less than 10 shields have 0 bribe cost.

  /common/unit.c::unit_bribe_cost()
  blamed lines of code:
  @ /* Consider the build cost. */
  cost *= (unit_build_shield_cost_base(punit) / 10;@
  FIX: Forcing those to (float) fixed it at FCW, but note, FCW version of this function ...

2021-06-01

• 
  Lexxie L Freeciv

  06:34 PM · Commented on issue

  I forgot to mention, fcw.org version of the code has previously fixed other similar maths bugs involving rounding and etc., such as a bug that made negative bribe costs where you got PAID to bribe units. Bug #929034: Units costing less than 10 shields have 0 bribe cost.

  /common/unit.c::unit_bribe_cost()
  blamed lines of code:
  @ /* Consider the build cost. */
  cost *= (unit_build_shield_cost_base(punit) / 10;@
  FIX: Forcing those to (float) fixed it at FCW, but note, FCW version of this function ...
• 
  Lexxie L /common/unit.c::unit_bribe_cost()
  blamed lines of code:
  @ /* Consider the build cost. */
  cost *= (unit_build_shield_cost_base(punit) / 10;@
  FIX: Forcing those to (float) fixed it at FCW, but note, FCW version of this function ...

  06:31 PM · Closed issue

2021-05-29

• 
  Lexxie L Freeciv

  01:09 AM · Commented on issue

  This is the only tangible long range air threat the AI provides to challenge single players, and it's effective and real. Removing it is a step backward for playability in my opinion. Better to leave it in and just wait for AI to be sma... Bug #924325: AI: don't build units losing hp until we can manage them

  The AI is noticed to build helicopters but it can't manage them unless it owns UNO. So it should not build them. We can want techs that allow us helicopters with desire scaled to the probability we'll ever have UNO, but as a quick soluti...
• 
  Lexxie L Freeciv

  11:56 PM · Commented on issue

  Foreground and background sprites for new base type "castle". This has two variants.
  base.castle has a "courtyard" inside which allows seeing the terrain this base is built on. It is still closed enough to make it credible why you can... Feature #919768: Castle art request

  The sandbox ruleset's Castle extra doesn't have any art. It currently uses the Fortress graphics since it is an upgrade to it.
  In case details are needed to better create art for the Castle: The Castle is an upgrade to the Fortress ex...
• 
  Lexxie L Freeciv

  06:48 PM · Commented on issue

  Assuming someone wants to do the work, it's possible for rulesets to specify whether this is a rare_popup, OR a logic condition figures out if it's rare_popup
  1. I think in many rules, embark of 1 mp will be greater than move cost of ... Bug #928837: EMBARK action should be created as a rare_pop_up

  Playtesting revealed lots of units with GOTO orders to cities, spammed an intolerable amount of Pop-ups asking whether the unit wants to EMBARK on some unit inside which can take cargo. This also leaves the units stranded unsafe outside ...
• 
  Lexxie L 3.2 version of the patch:

  02:53 AM · Commented on issue

2021-05-28

• 
  Lexxie L Freeciv

  01:33 AM · Closed issue

  Bug #928837 (Closed): EMBARK action should be created as a rare_pop_up

  Playtesting revealed lots of units with GOTO orders to cities, spammed an intolerable amount of Pop-ups asking whether the unit wants to EMBARK on some unit inside which can take cargo. This also leaves the units stranded unsafe outside ...

2021-05-03

• 
  Lexxie L Freeciv

  08:03 PM · Commented on issue

  Sveinung Kvilhaugsvik wrote:
  > Lexxie L wrote:
  > > I do not understand the actionenabler idea, he must mean some kind of automatic re-homing that the server does as an action instead of the user. If it finds that re-homing from far dis... Feature #926251: Unit home city loss

  "When a city is lost in war, units outside the city may be lost. This is fine, especially in early games where it is reasonable that a unit is loyal to its city more than its nation, but in mid-late game it's more likely that the unit is...
• 
  Lexxie L Sveinung Kvilhaugsvik wrote:
  > Lexxie L wrote:
  > > Nationwide upkeep has no way to handle shield upkeep.
  >
  > The suggestion is to create national upkeep for shield upkeep. I'm not sure if Ignatiev has the exact same idea that I have...

  07:59 PM · Commented on issue